[tor-commits] [tor/master] Fix a bug in practracker's handling of .may_include in headers

[dgoulet@xxxxxxxxxxxxxx]

commit 318de94e49c99335987bfdead899c29908afc5bc
Author: Nick Mathewson <nickm@xxxxxxxxxxxxxx>
Date:   Mon Aug 26 12:30:18 2019 -0400

    Fix a bug in practracker's handling of .may_include in headers
    
    I was expecting our filter code to work in a way it didn't.  I
    thought that saying that DependencyViolation applied to "*" would
    hit all of the files -- but actually, "*" wasn't implemented.  I had
    to say "*.c" and "*.h"
---
 scripts/maint/practracker/practracker.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/scripts/maint/practracker/practracker.py b/scripts/maint/practracker/practracker.py
index 6483b88da..b280a7676 100755
--- a/scripts/maint/practracker/practracker.py
+++ b/scripts/maint/practracker/practracker.py
@@ -213,7 +213,8 @@ def main(argv):
     filt.addThreshold(problem.FileSizeItem("*.h", int(args.max_h_file_size)))
     filt.addThreshold(problem.IncludeCountItem("*.h", int(args.max_h_include_count)))
     filt.addThreshold(problem.FunctionSizeItem("*.c", int(args.max_function_size)))
-    filt.addThreshold(problem.DependencyViolationItem("*", int(args.max_dependency_violations)))
+    filt.addThreshold(problem.DependencyViolationItem("*.c", int(args.max_dependency_violations)))
+    filt.addThreshold(problem.DependencyViolationItem("*.h", int(args.max_dependency_violations)))
 
     # 1) Get all the .c files we care about
     files_list = util.get_tor_c_files(TOR_TOPDIR)



_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits