[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

[tor-commits] [Git][tpo/applications/tor-browser][tor-browser-115.2.1esr-13.0-1] fixup! Bug 30237: Add v3 onion services client authentication prompt

Title: GitLab

richard pushed to branch tor-browser-115.2.1esr-13.0-1 at The Tor Project / Applications / Tor Browser

Commits:

  • 0ce95033
    by Henry Wilkes at 2023-09-15T20:11:51+00:00 
    fixup! Bug 30237: Add v3 onion services client authentication prompt

Bug 42092: Fix layout styling of saved onion keys dialog.

3 changed files:

Changes:

  • browser/components/onionservices/content/authPreferences.css
    ... ... @@ -3,7 +3,11 @@
    3 3 
     @import url("chrome://browser/skin/browser-colors.css");
    4 4
    5 5 
     #torOnionServiceKeys-overview-container {
    6 
    -  margin-right: 30px;
    6 
    +  margin-inline-end: 30px;
    7 
    +}
    8 
    +
    9 
    +#onionservices-savedkeys-dialog {
    10 
    +  min-width: 45em;
    7 11 
     }
    8 12
    9 13 
     #onionservices-savedkeys-tree treechildren::-moz-tree-cell-text {
    ... ... @@ -11,14 +15,17 @@
    11 15 
     }
    12 16
    13 17 
     #onionservices-savedkeys-errorContainer {
    14 
    -  margin-top: 4px;
    18 
    +  margin-block-start: 4px;
    15 19 
       min-height: 3em;
    16 20 
     }
    17 21
    22 
    +#onionservices-savedkeys-errorContainer:not(.show-error) {
    23 
    +  visibility: hidden;
    24 
    +}
    25 
    +
    18 26 
     #onionservices-savedkeys-errorIcon {
    19 
    -  margin-right: 4px;
    27 
    +  margin-inline-end: 4px;
    20 28 
       list-style-image: url("chrome://global/skin/icons/warning.svg");
    21 29 
       -moz-context-properties: fill;
    22 30 
       fill: var(--warning-color);
    23 
    -  visibility: hidden;
    24 31 
     }

  • browser/components/onionservices/content/savedKeysDialog.js
    ... ... @@ -189,10 +189,10 @@ var gOnionServicesSavedKeysDialog = {
    189 189 
       },
    190 190
    191 191 
       _showError(aMessage) {
    192 
    -    const dialog = document.querySelector(this.selector.dialog);
    193 
    -    const errorIcon = dialog.querySelector(this.selector.errorIcon);
    194 
    -    errorIcon.style.visibility = aMessage ? "visible" : "hidden";
    195 
    -    const errorDesc = dialog.querySelector(this.selector.errorMessage);
    192 
    +    document
    193 
    +      .getElementById("onionservices-savedkeys-errorContainer")
    194 
    +      .classList.toggle("show-error", !!aMessage);
    195 
    +    const errorDesc = document.querySelector(this.selector.errorMessage);
    196 196 
         errorDesc.textContent = aMessage ? aMessage : "";
    197 197 
       },
    198 198

  • browser/components/onionservices/content/savedKeysDialog.xhtml
    ... ... @@ -9,7 +9,6 @@
    9 9 
       id="onionservices-savedkeys-dialog"
    10 10 
       windowtype="OnionServices:SavedKeys"
    11 11 
       xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"
    12 
    -  style="width: 45em"
    13 12 
     >
    14 13 
       <script src="">"chrome://browser/content/onionservices/savedKeysDialog.js" />
    15 14
    ... ... @@ -23,8 +22,6 @@
    23 22 
           id="onionservices-savedkeys-tree"
    24 23 
           flex="1"
    25 24 
           hidecolumnpicker="true"
    26 
    -      width="750"
    27 
    -      style="height: 20em"
    28 25 
           onselect="gOnionServicesSavedKeysDialog.updateButtonsState();"
    29 26 
         >
    30 27 
           <treecols>
    ... ... @@ -38,7 +35,7 @@
    38 35 
           </treecols>
    39 36 
           <treechildren />
    40 37 
         </tree>
    41 
    -    <hbox id="onionservices-savedkeys-errorContainer" align="baseline" flex="1">
    38 
    +    <hbox id="onionservices-savedkeys-errorContainer" align="center">
    42 39 
           <image id="onionservices-savedkeys-errorIcon" />
    43 40 
           <description id="onionservices-savedkeys-errorMessage" flex="1" />
    44 41 
         </hbox>

    • —
    View it on GitLab.
    You're receiving this email because of your account on gitlab.torproject.org. Manage all notifications · Help 

    _______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits