[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [pygame] Patch for win-amd64





On 7/27/2011 4:45 AM, René Dudfield wrote:
Hi,

thanks.  Looks good to me.  You've changed some parts to Py_ssize_t and
c_ssize_t, from the 32bit types.

Do all the tests pass on 32bit as well?

I tested on 32 bit too: no new test failures. Only two remaining font related failures on all tested platforms:

======================================================================
FAIL: FontTypeTest.test_set_bold
----------------------------------------------------------------------
Traceback (most recent call last):
File "X:\Python32\lib\site-packages\pygame\tests\font_test.py", line 347, in test_set_bold
    self.failIf(f.get_bold())
AssertionError: None

======================================================================
FAIL: FontTypeTest.test_set_italic
----------------------------------------------------------------------
Traceback (most recent call last):
File "X:\Python32\lib\site-packages\pygame\tests\font_test.py", line 359, in test_set_italic
    self.failIf(f.get_bold())
AssertionError: None


Christoph



I'll try it out later tonight, and apply (unless Lenard beats me to it).

cheers!


On Tue, Jul 26, 2011 at 3:17 AM, Christoph Gohlke <cgohlke@xxxxxxx
<mailto:cgohlke@xxxxxxx>> wrote:

    Hello,

    please consider the attached patch. It fixes some array interface
    related crashes and test failures on the win-amd64 platform.

    Christoph