[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #3035 [Tor Client]: fix a few clang-static analyzer complaints in 0.2.2

#3035: fix a few clang-static analyzer complaints in 0.2.2
------------------------+---------------------------------------------------
 Reporter:  Sebastian   |          Owner:                    
     Type:  defect      |         Status:  needs_review      
 Priority:  normal      |      Milestone:  Tor: 0.2.2.x-final
Component:  Tor Client  |        Version:                    
 Keywords:              |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------

Comment(by arma):

 {{{
  #define CONN_LOG_PROTECT(conn, stmt)                                    \
    STMT_BEGIN                                                            \
 -    int _log_conn_is_control = (conn && conn->type == CONN_TYPE_CONTROL);
 \
 +    int _log_conn_is_control;                                           \
 +    tor_assert(conn);                                                   \
 +    _log_conn_is_control = (conn->type == CONN_TYPE_CONTROL);           \
 }}}

 What if tor_assert triggers, causing us to do a log to the controller at
 the same time, which would want to disable logging, ...

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3035#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs