[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #5647 [Tor Hidden Services]: rend_parse_client_keys() prints stack in logs if base64_decode fails

#5647: rend_parse_client_keys() prints stack in logs if base64_decode fails
---------------------------------+------------------------------------------
 Reporter:  asn                  |          Owner:                  
     Type:  defect               |         Status:  new             
 Priority:  normal               |      Milestone:  Tor: unspecified
Component:  Tor Hidden Services  |        Version:                  
 Keywords:                       |         Parent:                  
   Points:                       |   Actualpoints:                  
---------------------------------+------------------------------------------

Comment(by arma):

 If I'm reading this right, descriptor_cookie_base64's only role in life is
 to be an uninitialized string that we print in that log message. Fun.

 (I'm guessing we wanted to print tok->args[0] instead?)

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5647#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs