[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #8596 [Tor]: Inconsistent addrmap events when resolving hostname (regression)
#8596: Inconsistent addrmap events when resolving hostname (regression)
---------------------------------------+------------------------------------
Reporter: Desoxy | Owner:
Type: defect | Status: needs_review
Priority: normal | Milestone: Tor: 0.2.4.x-final
Component: Tor | Version: Tor: 0.2.4.11-alpha
Keywords: tor-client controller dns | Parent:
Points: | Actualpoints:
---------------------------------------+------------------------------------
Changes (by Desoxy):
* status: new => needs_review
Comment:
> (The cache is not actually per-circuit. Mostly, we just don't cache at
the client side at all. This is approximately equivalent to a per-circuit
cache, since the exit node caches too. Is there a lingering documentation
bug too?)
No, I only skimmed the documentation and simply misunderstood the change.
> If it turns out that Vidalia or controller can't cope with a new
flag, it would be bad to have to delay 0.2.4 packages until that
controller could catch up.
I have not found Vidalia listening for ADDRMAP events. Stem ignores
unknown arguments, but changes are required to access the value of the new
flag.
> If the fix is tricky enough, it would be bad to delay 0.2.4 stability
for it.
There is already code for sending an ADDRMAP event as response to RESOLVE
requests, because failed resolves do not get added to the cache and would
thus not generate such events. Changing this code to also generate an
ADDRMAP event on success is all that is needed. The attached patch does
this and also adds a new flag CACHE="YES"/"NO" to ADDRMAP events.
Example events:
{{{
(Generated with tor-resolve:)
650 ADDRMAP example.com 192.0.43.10 "2013-04-03 11:00:52"
EXPIRES="2013-04-03 09:00:52" CACHE="YES"
(Gerated with RESOLV command:)
650 ADDRMAP example.com 192.0.43.10 "2013-04-03 08:28:51"
EXPIRES="2013-04-03 06:28:51" CACHE="NO"
650 ADDRMAP example.invalid <error> "2013-04-03 08:28:52"
error=yes EXPIRES="2013-04-03 06:28:52" CACHE="NO"
}}}
If this patch is acceped, I will change the controller spec to include
information about the CACHE flag.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8596#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs