Re: [tor-bugs] #18793 [Metrics/CollecTor]: add checkstyle task

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#18793: add checkstyle task
-------------------------------+------------------------------
 Reporter:  iwakeh             |          Owner:  iwakeh
     Type:  enhancement        |         Status:  needs_review
 Priority:  Medium             |      Milestone:
Component:  Metrics/CollecTor  |        Version:
 Severity:  Normal             |     Resolution:
 Keywords:  ctip               |  Actual Points:
Parent ID:                     |         Points:
 Reviewer:                     |        Sponsor:
-------------------------------+------------------------------

Comment (by iwakeh):

 Good to use more specific .gitignore patterns!
 All looks fine!

 Regarding the style corrections:
 It would be great if you could make the bulk corrections!
 I though about tackling style issues when touching the code anyway;
 like with the additional renaming patch in this issue.

 I'll add a coding style polishing issue with a "nice to have soon list".


 Anyway, for not having used any coding metrics before in this project and
 also considering that many checkstyle complaints are due to the old style,
 this code base is in pretty good shape checkstyle-wise.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18793#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs