[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #16849 [Core Tor/Tor]: clear_status_flags_on_sybil might want to clear more flags
#16849: clear_status_flags_on_sybil might want to clear more flags
-------------------------------------------------+-------------------------
Reporter: teor | Owner:
| ffmancera
Type: defect | Status:
| needs_review
Priority: High | Milestone: Tor:
| 0.3.4.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: easy, SponsorS-deferred, technical- | Actual Points:
debt, tor-dirauth, pending-disaster, review- |
group-32, review-group-34, |
034-triage-20180328 |
Parent ID: | Points: small
Reviewer: nickm | Sponsor:
-------------------------------------------------+-------------------------
Changes (by ffmancera):
* status: needs_revision => needs_review
Comment:
> We should use memcpy() to copy the identity and descriptor digests:
strncpy will stop copying if those digests contain any 0-valued bytes.
> We should use strlcpy() and sizeof() to copy the nickname.
Done!
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16849#comment:33>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs