Re: [tor-bugs] #30213 [Core Tor/Tor]: Remove sudo: false from Travis

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#30213: Remove sudo: false from Travis
------------------------------------+----------------------------------
 Reporter:  teor                    |          Owner:  (none)
     Type:  defect                  |         Status:  needs_revision
 Priority:  Medium                  |      Milestone:  Tor: unspecified
Component:  Core Tor/Tor            |        Version:
 Severity:  Normal                  |     Resolution:
 Keywords:  technical-debt, tor-ci  |  Actual Points:
Parent ID:                          |         Points:  0.5
 Reviewer:                          |        Sponsor:
------------------------------------+----------------------------------
Changes (by teor):

 * status:  new => needs_revision


Comment:

 Each rule is an array of match criteria, starting with "-".

 These rules mean "exclude clang builds with no sudo" and "exclude gcc
 builds with sudo":
 {{{
   exclude:
     ## Clang doesn't work in containerized builds, see below.
     - compiler: clang
       sudo: false
     ## Non-containerized gcc are slow and redundant.
     - compiler: gcc
       sudo: required
     ## gcc on OSX is less useful, because the default compiler is clang.
     - compiler: gcc
       os: osx
 }}}

 Your patch replaces them with: "exclude clang builds" and "exclude gcc
 builds" (and then you reverted one of those changes):
 {{{
   exclude:
     ## Clang doesn't work in containerized builds, see below.
     - compiler: clang
     ## Non-containerized gcc are slow and redundant.
     - compiler: gcc
     ## gcc on OSX is less useful, because the default compiler is clang.
     - compiler: gcc
       os: osx
 }}}

 Instead, remove the entire rule, for every rule that mentions sudo:
 {{{
   exclude:
     ## gcc on OSX is less useful, because the default compiler is clang.
     - compiler: gcc
       os: osx
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30213#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs