[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #29209 [Core Tor/Tor]: Reduce visibility of more data type internals
#29209: Reduce visibility of more data type internals
----------------------------------------+----------------------------------
Reporter: nickm | Owner: (none)
Type: task | Status: needs_review
Priority: Medium | Milestone: Tor:
| 0.4.1.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: technical-debt refactoring | Actual Points: 3.5
Parent ID: | Points: 15
Reviewer: nickm | Sponsor: Sponsor31-can
----------------------------------------+----------------------------------
Comment (by nickm):
Reading the C99 spec (section 6.2.7) I don't think options 2 is good C:
>1. Two types have compatible type if their types are the same...
Moreover, two structure,union, or enumerated types declared in
separate translation units are compatible if their tags and
members satisfy the following requirements: ... there shall be a one-
to-one correspondence between their members such that each pair of
corresponding members are declared with compatible types, and such
that if one member of a corresponding pair is declared with a name, the
other member is declared with the same name.
>
>2.All declarations that refer to the same object or function
shall have compatible type;otherwise, the behavior is undefined.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29209#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs