[tor-bugs] #33782 [Core Tor/Tor]: Increases TEST_CONN_FD_INIT to make tests working on GitHub Actions

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#33782: Increases TEST_CONN_FD_INIT to make tests working on GitHub Actions
------------------------------+------------------------------
 Reporter:  ultimaweapon      |          Owner:  (none)
     Type:  defect            |         Status:  new
 Priority:  Medium            |      Component:  Core Tor/Tor
  Version:  Tor: unspecified  |       Severity:  Normal
 Keywords:                    |  Actual Points:
Parent ID:                    |         Points:
 Reviewer:                    |        Sponsor:
------------------------------+------------------------------
 With the current value, which is 50; it will cause some tests to fail on
 GitHub Actions:

 {{{
 hs_client/e2e_rend_circuit_setup_legacy: [forking] Mar 31 17:01:17.348
 [warn] tor_bug_occurred_(): Bug: src/lib/net/socket.c:237:
 tor_close_socket__real: Non-fatal assertion n_sockets_open >= 0 failed.
 (on Tor 0.4.2.5 )
 Mar 31 17:01:17.349 [warn] Bug: Tor 0.4.2.5: Non-fatal assertion
 n_sockets_open >= 0 failed in tor_close_socket__real at
 src/lib/net/socket.c:237. Stack trace: (on Tor 0.4.2.5 )
 Mar 31 17:01:17.349 [warn] Bug:
 ./src/test/test(log_backtrace_impl+0x56) [0x55d2831c7696] (on Tor 0.4.2.5
 )
 Mar 31 17:01:17.349 [warn] Bug:
 ./src/test/test(tor_bug_occurred_+0x17f) [0x55d2831c2fcf] (on Tor 0.4.2.5
 )
 Mar 31 17:01:17.349 [warn] Bug:
 ./src/test/test(tor_close_socket__real+0xd7) [0x55d2831ba3f7] (on Tor
 0.4.2.5 )
 Mar 31 17:01:17.349 [warn] Bug:
 ./src/test/test(connection_free_minimal+0x1c7) [0x55d28302a507] (on Tor
 0.4.2.5 )
 Mar 31 17:01:17.349 [warn] Bug:     ./src/test/test(+0x2d5dff)
 [0x55d282e91dff] (on Tor 0.4.2.5 )
 Mar 31 17:01:17.349 [warn] Bug:     ./src/test/test(+0x444c66)
 [0x55d283000c66] (on Tor 0.4.2.5 )
 Mar 31 17:01:17.349 [warn] Bug:
 ./src/test/test(testcase_run_one+0x2f1) [0x55d283000fb1] (on Tor 0.4.2.5 )
 Mar 31 17:01:17.349 [warn] Bug:     ./src/test/test(tinytest_main+0x10c)
 [0x55d28300156c] (on Tor 0.4.2.5 )
 Mar 31 17:01:17.349 [warn] Bug:     ./src/test/test(main+0x2a0)
 [0x55d282cad9f0] (on Tor 0.4.2.5 )
 Mar 31 17:01:17.349 [warn] Bug:     /lib/x86_64-linux-
 gnu/libc.so.6(__libc_start_main+0xe7) [0x7f65fdf83b97] (on Tor 0.4.2.5 )
 Mar 31 17:01:17.349 [warn] Bug:     ./src/test/test(_start+0x2a)
 [0x55d282cadb1a] (on Tor 0.4.2.5 )

   [e2e_rend_circuit_setup_legacy FAILED]
 }}}

 The reason is because of a process running in GitHub Actions doing
 something that caused a lot of file descriptors to open. So, when Tor is
 trying to close a fake socket it ends up closing a real one that was
 opened by GitHub Actions.

 I already tried with 100 and it does not work. So I tried 200 and it
 works.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33782>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs