[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #33609 [Core Tor/Chutney]: Check that onion services have successfully posted descriptors before verifying



#33609: Check that onion services have successfully posted descriptors before
verifying
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  c
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:
Component:  Core Tor/Chutney                     |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  ipv6, prop311, outreachy-ipv6, easy  |  Actual Points:
Parent ID:  #33050                               |         Points:  1
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor55-can
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  assigned => needs_revision


Comment:

 Replying to [comment:7 c]:
 > I have an in-progress branch on my site:
 >
 > `git clone -b c/check-onion-descriptors
 git://code.chroniko.jp/~c/chutney.git`
 >
 > I'll see if I can make a PR to GitHub once my changes are complete and
 ready for a full review.

 Thanks, this is really good code.

 It looks like you are checking for onion service descriptor uploads for
 all nodes. But you only need to check for onion services.

 The `getOnionService()` function should tell you if the current node is an
 onion service.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33609#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs