[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #33617 [Core Tor/Tor]: Add a BandwidthStatistics option and consensus parameter
#33617: Add a BandwidthStatistics option and consensus parameter
-------------------------------------------------+-------------------------
Reporter: teor | Owner:
| MrSquanchee
Type: enhancement | Status:
| needs_review
Priority: Medium | Milestone: Tor:
| 0.4.4.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: extra-review, prop313, ipv6, | Actual Points:
outreachy-ipv6, network-team-roadmap-2020Q1 |
Parent ID: #33052 | Points: 1
Reviewer: | Sponsor:
| Sponsor55-can
-------------------------------------------------+-------------------------
Changes (by teor):
* keywords: prop313, ipv6, outreachy-ipv6, network-team-roadmap-2020Q1 =>
extra-review, prop313, ipv6, outreachy-ipv6, network-team-roadmap-
2020Q1
Comment:
Replying to [comment:33 MrSquanchee]:
> Replying to [comment:32 teor]:
> > We've been a bit busy for the past few weeks. I was also waiting for
you to write more tests.
>
> I thought we were done with the tests. Can you please tell me what
functions do you want to have
> tests for ??
We should test all the functions that have been modified. Sometimes we
decide to do unit tests later, and open another ticket. Other times we ask
for them as part of the PR, so we are sure that the new code works.
We don't have good integration tests for this code, so unit tests are
important.
I'll leave it to the next reviewer to decide if we need more tests.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33617#comment:35>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs