[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #1773 [Tor - Relay]: Use curly braces for variable expansion in makefiles.

#1773: Use curly braces for variable expansion in makefiles.
--------------------------+-------------------------------------------------
  Reporter:  ln5          |       Owner:  ln5         
      Type:  defect       |      Status:  needs_review
  Priority:  minor        |   Milestone:              
 Component:  Tor - Relay  |     Version:              
Resolution:               |    Keywords:              
    Parent:               |  
--------------------------+-------------------------------------------------

Comment(by ln5):

 It has nothing to do with GNU Make.  One could argue that Automake is
 wrong here but I haven't looked into it.  They seem to warn like this when
 you do non-portable things if I understand things correctly, which might
 be a hint that this is not a good idea.  I have tested with GNU make and
 BSD make (netbsd) but only with a recent version of each.

 Another option, as discussed with Sebastian on #tor-dev the other day,
 would be to set the makefile variables using this expansion thing within
 the 'if USE_ASCIIDOC' clause.  A  bit cludgy, admittedly.

 I've pushed the s/:=/::=/ change to my makefile-var-exp in case you'd like
 to merge.  I hope that branch is in proper shape, please tell if it's not.
 We don't need another changes file, do we?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1773#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs