[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #6475 [Tor Client]: circuit_send_next_onion_skin(): Bug: Unexpectedly high circuit_successes
#6475: circuit_send_next_onion_skin(): Bug: Unexpectedly high circuit_successes
-----------------------------+----------------------------------------------
Reporter: grarpamp | Owner: mikeperry
Type: defect | Status: assigned
Priority: major | Milestone: Tor: 0.2.3.x-final
Component: Tor Client | Version: Tor: 0.2.3.19-rc
Keywords: MikePerry201208 | Parent:
Points: | Actualpoints:
-----------------------------+----------------------------------------------
Comment(by nickm):
mentioning this here so I don't forget:
{{{
18:45 < nickm> so the kludgey fix I thought is this:
18:46 < nickm> add a flag to origin_circuit_t
18:46 < nickm> That flag is: "Have we counted this circuit's first hop?"
18:46 < nickm> If it's set to 1, we do not count the first hop.e
18:46 < nickm> when we count the first hop, we set it to 1.
18:46 < nickm> if it's set to 0, we do not count the circuit as having
succeeded.
18:47 < nickm> when we count the circuit as having succeeded, we set it to
0
18:47 < nickm> plus side: no investigation would be needed
18:47 < nickm> minus side: we would never understand why this bug
happened!
18:48 < nickm> plus side: future bugs of this kind couldn't occur
18:48 < nickm> plus side: if we added debugging code when we tried to
count a
circuit as successful with the flag set to 0, then we might
track down where this bug was.
}}}
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6475#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs