[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #12866 [Onionoo]: cycle between util and docs packages

#12866: cycle between util and docs packages
-------------------------+-----------------
     Reporter:  iwakeh   |      Owner:
         Type:  defect   |     Status:  new
     Priority:  normal   |  Milestone:
    Component:  Onionoo  |    Version:
   Resolution:           |   Keywords:
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+-----------------

Comment (by karsten):

 Agreed that circular dependencies are a bad idea.  I split up the
 ApplicationFactory class into four factory classes.  Do you mind reviewing
 the changes?
 https://gitweb.torproject.org/user/karsten/onionoo.git/shortlog/refs/heads/task-12866

 However, I'm not convinced that DateTimeHelper should move to the docs
 package.  It's a utility class used by many other classes in the other
 packages.  Moving it to the docs package seems arbitrary.  Thoughts?

 FWIW, the dependency between Logger and DateTimeHelper could be removed by
 simply defining ONE_SECOND and ONE_MINUTE in Logger.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12866#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs