[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #14846 [Tor]: Controller: retrieve an HS descriptor of a service run by a user
#14846: Controller: retrieve an HS descriptor of a service run by a user
-------------------------+-------------------------------------------------
Reporter: dgoulet | Owner: donncha
Type: | Status: needs_review
enhancement | Milestone: Tor: 0.2.7.x-final
Priority: trivial | Version: Tor: 0.2.7
Component: Tor | Keywords: SponsorR, tor-hs, controller,
Resolution: | 027-triaged-1-in, SponsorS, TorCoreTeam201508
Actual Points: | Parent ID: #3521
Points: small |
-------------------------+-------------------------------------------------
Comment (by nickm):
Note: this branch is much easier to review if you consider it as a single
patch, with whitespace changes suppressed. For me, that's:
{{{
git diff -b master...donnchac/feature14846_2
}}}
Overall notes:
* It makes me a little bit nervous to have a single function to handle
server-side and client-side lookups.
* I think we should name the "service cache" to make it clear that it's
our own descriptors we're asking about.
* rend_cache_store_v2_desc_as_service() appears to be mostly duplicate
code from rend_desc_cache_store_v2_desc_as_client(). Duplicate code
usually indicates an opportunity for a function.
* I wonder if this will conflict with any of dgoulet's patches for
#16389.
* Does anything ever expire entries from rend_cache_service, or do they
stick around forever? (Currently this is handled for the other cache in
rend_cache_clean.)
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/14846#comment:18>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs