[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #19903 [Core Tor/Tor]: tor_tls_get_by_ssl is declared non-inline, then inline.

#19903: tor_tls_get_by_ssl is declared non-inline, then inline.
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  nickm
     Type:  defect                               |         Status:
                                                 |  needs_information
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.2.8.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Minor                                |     Resolution:
 Keywords:  openbsd, TorCoreTeam201608,          |  Actual Points:  0
  028-backport, review-group-7                   |
Parent ID:                                       |         Points:  0
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by dgoulet):

 * status:  needs_review => needs_information


Comment:

 I have to agree with cypherpunks here, why is this inline at all? Not sure
 we need the `STATIC_INLINE` being used _once_ for a function that could be
 non-inline.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19903#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs