[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #23588 [Core Tor/Tor]: Write fascist_firewall_choose_address_ls() and use it in hs_get_extend_info_from_lspecs()



#23588: Write fascist_firewall_choose_address_ls() and use it in
hs_get_extend_info_from_lspecs()
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  neel
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.5.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  prop224, tor-hs, single-onion,       |  Actual Points:
  ipv6, 034-triage-20180328,                     |
  034-removed-20180328                           |
Parent ID:  #23493                               |         Points:  1
 Reviewer:  teor                                 |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by teor):

 Thanks!

 I added a commit to your branch with some more comment fixes based on:
 https://github.com/torproject/tor/pull/256#discussion_r208425879
 https://github.com/torproject/tor/pull/256#pullrequestreview-144234103
 And I fixed another outdated function comment.

 I also ran `make test-network-all` on the branch, using the chutney fix
 from #27067.

 And I got the following errors:
 {{{
 $ make test-network-all
 mkdir -p ./test_network_log
 ping6 ::1 or ping ::1 succeeded, running IPv6 flavors: bridges+ipv6-min
 ipv6-exit-min hs-v23-ipv6-md single-onion-ipv6-md.
 tor-stable found, running mixed flavors: mixed+hs-v23.
 FAIL: basic-min
 FAIL: bridges-min
 PASS: hs-v2-min
 PASS: hs-v3-min
 Detail: chutney/tools/warnings.sh /Users/base/chutney/net/nodes.1533723794
 Warning: tor_addr_is_null: Bug: Called with unknown address family 214 (on
 Tor 0.3.5.0-alpha-dev 52941e3283a40281) Number: 1
 Warning: tor_addr_is_null: Bug: Called with unknown address family 32 (on
 Tor 0.3.5.0-alpha-dev 52941e3283a40281) Number: 1
 PASS: single-onion-v23
 Detail: chutney/tools/warnings.sh /Users/base/chutney/net/nodes.1533723833
 Warning: tor_addr_is_null: Bug: Called with unknown address family 214 (on
 Tor 0.3.5.0-alpha-dev 52941e3283a40281) Number: 1
 Warning: tor_addr_is_null: Bug: Called with unknown address family 32 (on
 Tor 0.3.5.0-alpha-dev 52941e3283a40281) Number: 1
 PASS: bridges+ipv6-min
 PASS: ipv6-exit-min
 FAIL: hs-v23-ipv6-md
 Detail: chutney/tools/warnings.sh /Users/base/chutney/net/nodes.1533723949
 Warning: Bug:     0   tor
 0x000000010bdb0a2c log_backtrace_impl + 76 (on Tor 0.3.5.0-alpha-dev
 52941e3283a40281) Number: 2
 Warning: Bug:     1   tor
 0x000000010bda1177 tor_bug_occurred_ + 503 (on Tor 0.3.5.0-alpha-dev
 52941e3283a40281) Number: 2
 Warning: Bug:     10  tor
 0x000000010b83fc17 do_main_loop + 2423 (on Tor 0.3.5.0-alpha-dev
 52941e3283a40281) Number: 2
 Warning: Bug:     11  tor
 0x000000010b8445fb tor_run_main + 779 (on Tor 0.3.5.0-alpha-dev
 52941e3283a40281) Number: 2
 Warning: Bug:     12  tor
 0x000000010b9a54a1 tor_main + 161 (on Tor 0.3.5.0-alpha-dev
 52941e3283a40281) Number: 2
 Warning: Bug:     13  tor
 0x000000010b7a039b main + 27 (on Tor 0.3.5.0-alpha-dev 52941e3283a40281)
 Number: 2
 Warning: Bug:     14  libdyld.dylib
 0x00007fff54fbe015 start + 1 (on Tor 0.3.5.0-alpha-dev 52941e3283a40281)
 Number: 2
 Warning: Bug:     2   tor
 0x000000010bac2f6e hs_client_dir_info_changed + 206 (on Tor 0.3.5.0-alpha-
 dev 52941e3283a40281) Number: 2
 Warning: Bug:     3   tor
 0x000000010bb16b9c networkstatus_set_current_consensus + 9740 (on Tor
 0.3.5.0-alpha-dev 52941e3283a40281) Number: 2
 Warning: Bug:     4   tor
 0x000000010ba59e11 connection_dir_client_reached_eof + 20913 (on Tor
 0.3.5.0-alpha-dev 52941e3283a40281) Number: 2
 Warning: Bug:     5   tor
 0x000000010ba54a1f connection_dir_reached_eof + 143 (on Tor 0.3.5.0-alpha-
 dev 52941e3283a40281) Number: 2
 Warning: Bug:     6   tor
 0x000000010b8210d4 connection_handle_read + 11668 (on Tor 0.3.5.0-alpha-
 dev 52941e3283a40281) Number: 2
 Warning: Bug:     7   tor
 0x000000010b836938 conn_read_callback + 88 (on Tor 0.3.5.0-alpha-dev
 52941e3283a40281) Number: 2
 Warning: Bug:     8   libevent-2.1.6.dylib
 0x000000010c7839c2 event_process_active_single_queue + 1057 (on Tor
 0.3.5.0-alpha-dev 52941e3283a40281) Number: 2
 Warning: Bug:     9   libevent-2.1.6.dylib
 0x000000010c780cb3 event_base_loop + 1074 (on Tor 0.3.5.0-alpha-dev
 52941e3283a40281) Number: 2
 Warning: Bug: Non-fatal assertion !(status == HS_CLIENT_FETCH_HAVE_DESC)
 failed in retry_all_socks_conn_waiting_for_desc at
 ../src/feature/hs/hs_client.c:275. Stack trace: (on Tor 0.3.5.0-alpha-dev
 52941e3283a40281) Number: 2
 Warning: Every introduction point for service
 ggdz6i6fshpuszndyqu373r7vzo2kltoofydyie2mtpv4rketkixxgad is unusable or we
 can't extend to it. We can't connect. Number: 7
 Warning: Not enough info to open a circuit to a rendezvous point for
 hidden service ggdz6i6fshpuszndyqu373r7vzo2kltoofydyie2mtpv4rketkixxgad.
 Number: 1
 Warning: tor_addr_is_null: Bug: Called with unknown address family 214 (on
 Tor 0.3.5.0-alpha-dev 52941e3283a40281) Number: 43
 Warning: tor_addr_is_null: Bug: Called with unknown address family 32 (on
 Tor 0.3.5.0-alpha-dev 52941e3283a40281) Number: 2
 Warning: tor_bug_occurred_: Bug: ../src/feature/hs/hs_client.c:275:
 retry_all_socks_conn_waiting_for_desc: Non-fatal assertion !(status ==
 HS_CLIENT_FETCH_HAVE_DESC) failed. (on Tor 0.3.5.0-alpha-dev
 52941e3283a40281) Number: 2
 PASS: single-onion-ipv6-md
 PASS: mixed+hs-v23
 Log and result files are available in ./test_network_log.
 make: *** [test-network-all] Error 1
 Exit 2
 }}}

 But Tor master passes `make test-network-all`.

 I think that these errors happen because you're using tor_addr_t's without
 initialising them. See my comments on the pull request.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23588#comment:24>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs