[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #24629 [Core Tor/Tor]: Activate osx builds on travis, at low priority



#24629: Activate osx builds on travis, at low priority
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  teor
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.5.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  not-just-linux, tor-ci, teor-was-    |  Actual Points:
  assigned, 034-triage-20180328,                 |
  034-removed-20180328, 034-backport,            |
  035-removed-20180711, fast-fix                 |
Parent ID:                                       |         Points:  0.5
 Reviewer:  catalyst                             |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by catalyst):

 Thanks!  I'm commenting only on master, because I haven't looked at the
 others yet.

 This mostly looks good.

 `mkdir` in `before_install` should create
 `$TRAVIS_BUILD_DIR/src/rust/target`, not `$TRAVIS_BUILD_DIR/target`.

 Please explicitly delete the `CARGO_HOME` settings from
 src/rust/tor_rust/include.am and src/test/test_rust.sh instead of merging
 the changes from #26038.  There are other changes in #26038 that I think
 we don't want, like:
 * deleting the `registry` setting in `[source.crates-io]` in
 src/rust/.cargo/config.in; I'm not sure whether this breaks anything, but
 I'd rather play it safe and leave it there until we know why we should
 delete it.
 * warning if `CARGO_HOME` is set; I'm not sure the added complexity is
 worth it, especially given that the checks are added in at least four
 places.
 * explicit setting of `target-dir` in `[build]` in
 src/rust/.cargo/config.in; this seems redundant with the explicit setting
 of `CARGO_TARGET_DIR` in various cargo invocations.

 We could use `target-dir` in the cargo config instead of explicitly
 setting `CARGO_TARGET_DIR` for each cargo invocation, but in that case we
 should make a comment that it assumes that cargo is always invoked from a
 specific directory (which it should be after this change set).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24629#comment:29>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs