[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #24629 [Core Tor/Tor]: Activate osx builds on travis, at low priority



#24629: Activate osx builds on travis, at low priority
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  teor
     Type:  enhancement                          |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.5.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  not-just-linux, tor-ci, teor-was-    |  Actual Points:
  assigned, 034-triage-20180328,                 |
  034-removed-20180328, 034-backport,            |
  035-removed-20180711, fast-fix                 |
Parent ID:                                       |         Points:  0.5
 Reviewer:  catalyst                             |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:29 catalyst]:
 > Thanks!  I'm commenting only on master, because I haven't looked at the
 others yet.
 >
 > This mostly looks good.
 >
 > `mkdir` in `before_install` should create
 `$TRAVIS_BUILD_DIR/src/rust/target`, not `$TRAVIS_BUILD_DIR/target`.

 Done in my 0.3.2 and later branches.

 > Please explicitly delete the `CARGO_HOME` settings from
 src/rust/tor_rust/include.am and src/test/test_rust.sh instead of merging
 the changes from #26038.  There are other changes in #26038 that I think
 we don't want...

 Done in my 0.3.2 branch, and re-done in 0.3.3 because a file moved.

 Replying to [comment:28 teor]:
 > Ok, so this was quite challenging to backport, because there were a lot
 of little bugs. But I think it is worth it to have working CI.

 (And it's good to have consistent CI as well.)

 Here are the revised branches I created:
 * travis-osx-029 contains:
   * the travis config rewrite
   * macOS support
     * fix a bug where missing macOS dependencies weren't being installed
 (#27090, but backported as a precaution)
   * ccache (#26952)
   * asciidoc (#27087)
   * the distcheck configure options fix (#27088) for consistency
   * It passes Travis:
     * https://travis-ci.org/teor2345/tor/builds/414029807
   * And the full matrix also passes Travis:
     * https://travis-ci.org/teor2345/tor/builds/414069609
   * (I added a changes file and fixed some typos after the linked builds)
 * travis-osx-032 also contains:
   * the lzma and zstd (macOS only) install from 0.3.1
   * make zstd actually work on macOS (#27090)
   * rust cargo online mode
   * rust cargo offline mode
   * backport src/test/test_rust.sh from master
     * stop setting $CARGO_HOME (#26497)
     * Fix $abs_top_srcdir in test_rust.sh (#27093)
   * Use cargo cache (#26952)
   * It passes Travis:
     * https://travis-ci.org/teor2345/tor/builds/414327375
   * And the full matrix also passes Travis:
     * https://travis-ci.org/teor2345/tor/builds/414328388
   * (I added a changes file and fixed some typos after the linked builds)
 * travis-osx-033 also contains:
   * stop setting $CARGO_HOME, but in a different include.am file (#26497)
   * use a consistent working directory in builds and tests (#26497)
     * I didn't backport this patch to 0.3.2, because it has a different
 (but consistent) working directory
   * Use TOR_RUST_DEPENDENCIES (the name changed in 0.3.3)
   * Check Rust with distcheck (backport from 0.3.4, not supported in
 0.3.2)
   * use --all-features in test_rust.sh for 0.3.3 and 0.3.4 (existing code)
   * It passes Travis:
     * https://travis-ci.org/teor2345/tor/builds/414349039
   * And the full matrix is running in Travis:
     * https://travis-ci.org/teor2345/tor/builds/414354578
 * travis-osx-034 also contains:
   * Check disable module dirauth with and without rust (#27088 fix)
   * It is running in Travis:
     * https://travis-ci.org/teor2345/tor/builds/414351195
   * And the full matrix is running in Travis:
     * https://travis-ci.org/teor2345/tor/builds/414354648
 * travis-osx-master also contains:
   * revert use --all-features in test_rust.sh for 0.3.3 and 0.3.4
   * It is running in Travis:
     * https://travis-ci.org/teor2345/tor/builds/414352231
   * And the full matrix is running in Travis:
     * https://travis-ci.org/teor2345/tor/builds/414354615

 I don't know if we want to fix #27091 in jenkins or in tor, I've asked
 weasel on IRC. We shouldn't merge until we work out how to fix jenkins.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24629#comment:32>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs