[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #26998 [Metrics/Website]: Make suggested changes to per-graph CSV files and deploy them after August 15



#26998: Make suggested changes to per-graph CSV files and deploy them after August
15
-----------------------------+-----------------------------
 Reporter:  karsten          |          Owner:  karsten
     Type:  enhancement      |         Status:  merge_ready
 Priority:  Medium           |      Milestone:
Component:  Metrics/Website  |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:                   |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:                   |        Sponsor:
-----------------------------+-----------------------------

Comment (by karsten):

 Okay, great! I'm merging this now.

 Here's one smaller change that I'm also making, which is based on a bug
 report in an unrelated ticket:

 {{{
 diff --git a/src/main/R/rserver/graphs.R b/src/main/R/rserver/graphs.R
 index 2502c0e9..66a1414e 100644
 --- a/src/main/R/rserver/graphs.R
 +++ b/src/main/R/rserver/graphs.R
 @@ -895,7 +895,8 @@ plot_userstats <- function(start_p, end_p, node_p,
 variable_p, value_p,
      events_p, path_p) {
    load(paste(rdata_dir, "clients-", node_p, ".RData", sep = ""))
    c <- data
 -  u <- c[c$date >= start_p & c$date <= end_p, ]
 +  u <- c[c$date >= start_p & c$date <= end_p, c("date", "country",
 "transport",
 +      "version", "lower", "upper", "clients")]
    u <- rbind(u, data.frame(date = start_p,
        country = ifelse(variable_p == "country" & value_p != "all",
 value_p, ""),
        transport = ifelse(variable_p == "transport", value_p, ""),
 }}}

 I'm going to squash that change into 895a111 when rebasing to master.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26998#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs