[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #27253 [Core Tor/Stem]: Decide: rename Size subclasses to indicate unsigned and bit counts
#27253: Decide: rename Size subclasses to indicate unsigned and bit counts
-----------------------------------------+------------------------------
Reporter: dmr | Owner: atagar
Type: enhancement | Status: needs_review
Priority: Medium | Milestone:
Component: Core Tor/Stem | Version:
Severity: Normal | Resolution:
Keywords: client dev code-improvement | Actual Points:
Parent ID: | Points:
Reviewer: atagar | Sponsor:
-----------------------------------------+------------------------------
Comment (by atagar):
Hi Dave, sorry about the delay in getting to your pull request! It's
review season at work right now so bit stressed, and focusing on that
right now.
When it comes to the unsigned flag that is the *one* thing I already gave
a little thought to... and honestly reverted since I didn't understand a
point in it.
https://gitweb.torproject.org/user/atagar/stem.git/commit/?h=dmr_review
Quite possible thought this is actually for something upcoming?
> I wanted to make sure this got specifically addressed before a
stem.client release, since after that point it might be too late (due to
backwards-compatibility concerns).
Don't fret about stem.client when it comes to the release. We're not
vending this module at all in 1.7. We can continue to change it at will.
We *are* vending stem.descriptor.remote's new ORPort capabilities which
uses stem.client, but as long as that keeps working we're good.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27253#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs