[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #27287 [Core Tor/Tor]: make distcheck should run make check
#27287: make distcheck should run make check
--------------------------+------------------------------------
Reporter: teor | Owner: teor
Type: enhancement | Status: needs_review
Priority: Medium | Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor | Version: Tor: 0.3.0.1-alpha
Severity: Normal | Resolution:
Keywords: fast-fix | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
--------------------------+------------------------------------
Changes (by teor):
* status: assigned => needs_review
* version: => Tor: 0.3.0.1-alpha
* type: defect => enhancement
Comment:
`make check` runs `check-local`.
But it looks like `make distcheck` runs `check` without `check-local`.
It's not clear from the documentation if this is an intended behaviour:
https://www.gnu.org/software/automake/manual/automake.html#Extending
https://www.gnu.org/software/automake/manual/automake.html#Checking-the-
Distribution
I think we can fix this issue by adding a distcheck-hook that runs check-
local.
See my branch bug27287 on https://github.com/teor2345/tor.git for a fix.
CI is at:
* https://travis-ci.org/teor2345/tor/builds/419916130
* https://ci.appveyor.com/project/teor2345/tor/build/1.0.91
I tested it by failing `make check-spaces` with and without the fix:
* https://travis-ci.org/teor2345/tor/builds/419916464
* https://travis-ci.org/teor2345/tor/builds/419916765
If the fix works, distcheck jobs in the build without the fix will
succeed, but all jobs will fail in the build with the fix.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27287#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs