Re: [tor-bugs] #31343 [Core Tor/Tor]: appveyor: labs(time_t) is not allowed

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#31343: appveyor: labs(time_t) is not allowed
--------------------------+------------------------------------
 Reporter:  nickm         |          Owner:  (none)
     Type:  defect        |         Status:  new
 Priority:  Medium        |      Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  backports?    |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Comment (by nickm):

 On examination, this labs() doesn't belong here at all.  The code here is
 testing whether we are getting a NETINFO cell fairly soon after we sent a
 VERSIONS cell.  Using labs() makes it also test whether we are getting a
 NETINFO cell no earlier than 3 minutes '''before''' sending the VERSION
 cell, which is silly.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31343#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs