[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #28238 [Applications/Tor Browser]: Use mingw-w64/clang toolchain to build Firefox



#28238: Use mingw-w64/clang toolchain to build Firefox
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-rbm, tbb-9.0-must-nightly,       |  Actual Points:
  TorBrowserTeam201908R, GeorgKoppen201908       |
Parent ID:  #30322                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by gk):

 Replying to [comment:52 boklm]:
 > The patches from branch `gk/bug_28238_v16` look good to me.
 >
 > I think a possible improvement is defining `var/setup` in
 `projects/mingw-w64-clang/config` so that we can define `var/compiler` in
 the projects where we want to use it:
 > https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_28238_v2&id=1510201478c07569466e1fea83873dd1ffb4c1ca
 > https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_28238_v2&id=d93e89635eae1718b0c44be0d698e998754d4289
 > https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_28238_v2&id=5ef691810ea0e4f97d9262283947298756b88507
 >
 > In branch `bug_28238_v3` I squashed the suggested fixup patches, and
 rebased on master:
 > https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/log/?h=bug_28238_v3
 >
 > I am currently testing a build with this branch.

 Works for me and the fixups look good.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28238#comment:53>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs