[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #7687 [Stem]: RFC: add close_stream method to Controller

#7687: RFC: add close_stream method to Controller
-------------------------------+--------------------------------------------
 Reporter:  robinson           |          Owner:  atagar
     Type:  enhancement        |         Status:  new   
 Priority:  normal             |      Milestone:        
Component:  Stem               |        Version:        
 Keywords:  controller stream  |         Parent:        
   Points:                     |   Actualpoints:        
-------------------------------+--------------------------------------------

Comment(by atagar):

 Hi Sean. Generally I like it. I've pushed some additional tweaks to the
 'exp-close-stream-v1' branch of my personal repo
 (git://git.torproject.org/user/atagar/stem.git). Thoughts?

 https://gitweb.torproject.org/user/atagar/stem.git/shortlog/refs/heads
 /exp-close-stream-v1

 > 2) How do you feel about adding the SocksiPy <
 http://sourceforge.net/projects/socksipy/> module under test/ ?

 Generally I'd like to avoid it, but there is precedent...

 https://gitweb.torproject.org/stem.git/blob/HEAD:/stem/util/ordereddict.py

 Rather than bundling it how about we make it optional, skipping tests that
 use it if it's not present?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7687#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs