[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #6612 [Compass]: sort according to table header in Compass



#6612: sort according to table header in Compass
-------------------------+--------------------------------------------------
 Reporter:  gsathya      |          Owner:  gsathya       
     Type:  enhancement  |         Status:  needs_revision
 Priority:  normal       |      Milestone:                
Component:  Compass      |        Version:                
 Keywords:               |         Parent:                
   Points:               |   Actualpoints:                
-------------------------+--------------------------------------------------
Changes (by gsathya):

  * status:  new => needs_revision


Comment:

 Thanks a lot for the changes! This is a pretty big merge which changes a
 lot of things and I'm still only halfway through reviewing this. I wanted
 to hold of commenting on this until I finished the review, but I'd like to
 sort out a few things before we proceed.

 1) The URL's no longer change (it's not bookmark-able -- you can't share
 it). Is this ok? I distinctly remember arma wanting this in the beginning.
 2) Why use angular.js if the sorting is going to be done by the backend?
 3) When grouping by country, the fingerprint column only says "(XXX rel)"
 (should be "XXX relays") and remains a hyperlink.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6612#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs