[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #10342 [Obfsproxy]: make Circuit param a class attribute of Transport, instead of a per-method param
#10342: make Circuit param a class attribute of Transport, instead of a per-method
param
---------------------------+--------------------------
Reporter: infinity0 | Owner: infinity0
Type: defect | Status: needs_review
Priority: normal | Milestone:
Component: Obfsproxy | Version:
Resolution: | Keywords:
Actual Points: | Parent ID:
Points: |
---------------------------+--------------------------
Comment (by asn):
Patch looks plausible. I'll need to do another pass before merging.
I'm not sure if I want to rename `handshake()` to `circuitConnected()`
right now. I think I would prefer to do this after bananaphone and
scramblesuit get merged. David and Philipp, what do you think? If we do
this change, you will also need to change your codebase to reflect that.
In any case the `handshake()`->`circuitconnected()` rename should be a
commit of its own. And we should probably also mention it in the
`ChangeLog`.
Thanks for the code :)
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/10342#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs