[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #17696 [metrics-lib]: patch for missing torperf annotaion

#17696: patch for missing torperf annotaion
-------------------------+-------------------------
 Reporter:  iwakeh       |          Owner:  karsten
     Type:  defect       |         Status:  closed
 Priority:  Medium       |      Milestone:
Component:  metrics-lib  |        Version:
 Severity:  Normal       |     Resolution:  fixed
 Keywords:               |  Actual Points:
Parent ID:               |         Points:
  Sponsor:               |
-------------------------+-------------------------
Changes (by karsten):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Sounds like a reasonable rule not to change method input parameters.
 Changed back.  And merged to master.  Thanks!

 I'll also create a CollecTor ticket to add the missing @type annotations.
 But that doesn't affect this bug being fixed now, I think.  Resolving.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17696#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs