[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #17608 [Tor]: Refactor accept/reject * redundancy checks out of policies_parse_exit_policy_internal

#17608: Refactor accept/reject * redundancy checks out of
policies_parse_exit_policy_internal
---------------------------+------------------------------------
 Reporter:  teor           |          Owner:
     Type:  enhancement    |         Status:  closed
 Priority:  Very Low       |      Milestone:  Tor: 0.2.8.x-final
Component:  Tor            |        Version:  Tor: 0.2.7.3-rc
 Severity:  Minor          |     Resolution:  implemented
 Keywords:  easy refactor  |  Actual Points:
Parent ID:                 |         Points:
  Sponsor:                 |
---------------------------+------------------------------------
Changes (by nickm):

 * status:  needs_review => closed
 * resolution:   => implemented


Comment:

 Adding a couple more cleanup commits:
    * Since the variable is no longer modified, it should be called
 'policy' instead of 'dest'.  ("Dest" is short for "destination".)
    * Fixed the space issue that dgoulet found above.
    * Fixed the comment a little.
    * Used SMARTLIST_FOREACH_BEGIN/END rather than for loop.

 Also, merged.  Thanks!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17608#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs