[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #28764 [Applications/Tor Browser]: OpenSSL Build for Android



#28764: OpenSSL Build for Android
-------------------------------------------------+-------------------------
 Reporter:  sisbell                              |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-mobile, tbb-rbm,                 |  Actual Points:
  TorBrowserTeam201812                           |
Parent ID:  #28704                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):

 * status:  needs_review => needs_revision
 * keywords:  tbb-mobile, tbb-rbm, TorBrowserTeam201812R => tbb-mobile, tbb-
     rbm, TorBrowserTeam201812


Comment:

 Three things we should think about here:

 1) The OpenSSL output is not build reproducibly. The .a creation is not
 deterministic as it seems to contain timestamps, see:
 {{{
 0007ce70: 0000 0000 0000 0000 0000 6001 0000 0b00  ..........`.....
  0007ce80: 0000 0000 0000 0000 0000 0100 0000 0000  ................
  0007ce90: 0000 7373 6c5f 7574 7374 2e6f 2f20 2020  ..ssl_utst.o/
 -0007cea0: 2020 3135 3434 3532 3132 3032 2020 3130    1544521202  10
 +0007cea0: 2020 3135 3434 3532 3035 3032 2020 3130    1544520502  10
  0007ceb0: 3030 2020 3130 3030 2020 3130 3036 3434  00  1000  100644
  0007cec0: 2020 3736 3420 2020 2020 2020 600a 7f45    764       `..E
  0007ced0: 4c46 0101 0100 0000 0000 0000 0000 0100  LF..............
 }}}
 I wonder why that is necessary here. Maybe the cross-toolchain for Android
 does not have something like `-Wl,--no-insert-timestamp`?

 2) Do we really need all the exported env variables in the build script?
 The build seemed to work for me e.g. without declaring `RANLIB`?

 3) The comment in the config file should we wrapped so that we have it on
 two lines instead of one.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28764#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs