[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #32534 [Applications/Tor Browser]: settle on one canonical jtorctl

#32534: settle on one canonical jtorctl
-------------------------------------------------+-------------------------
 Reporter:  eighthave                            |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:  new
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  Android, tbb-mobile, jtorctl,        |  Actual Points:
  TorBrowserTeam202001                           |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by sisbell):

 Overall looks good. A few clarifications, questions.

  1. From an API perspective, the distinction between rawEventListeners and
 the EventHandlers isn't obvious. Why is one called handler and the other
 is called listener? What is the different? Should we use consistent terms?
  1. Better to use ArrayList.isEmpty rather than ArrayList.size() == 0
 (!TorControlConnection:221)
  1. What is the package name we are going with (net.freehaven? or
 org.torproject?)
  1. We do have clear SignalType enums, Does it make sense to use these for
 type safety?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32534#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs