Re: [tor-bugs] #5053 [Tor Bridge]: Fix IPv6 implementation for bridge statistics

["Tor Bug Tracker & Wiki" <torproject-admin@xxxxxxxxxxxxxx>]

#5053: Fix IPv6 implementation for bridge statistics
------------------------+---------------------------------------------------
 Reporter:  karsten     |          Owner:                    
     Type:  defect      |         Status:  needs_review      
 Priority:  major       |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Bridge  |        Version:                    
 Keywords:              |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------

Comment(by arma):

 {{{
 +  if (tor_addr_family(addr) != AF_INET)
 +    /*XXXX IP6 support ipv6 geoip.*/
 +    return -1;
 }}}

 While technically correct, because there's one line of code, there are two
 lines of stuff, and it will make C programmers twitch to see it. They'll
 twitch because somebody will go add another line someday and think he
 changed it from two lines to three, so there's no need to add braces, when
 actually he changed it from one line to two and there is a need.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5053#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs