Re: [tor-bugs] #5083 [Obfsproxy]: Implement heartbeat message in obfsproxy

["Tor Bug Tracker & Wiki" <torproject-admin@xxxxxxxxxxxxxx>]

#5083: Implement heartbeat message in obfsproxy
-------------------------+--------------------------------------------------
 Reporter:  karsten      |          Owner:  asn         
     Type:  enhancement  |         Status:  needs_review
 Priority:  normal       |      Milestone:              
Component:  Obfsproxy    |        Version:              
 Keywords:               |         Parent:              
   Points:               |   Actualpoints:              
-------------------------+--------------------------------------------------

Comment(by karsten):

 Replying to [comment:11 nickm]:
 > Reviewing the whole series as one diff...
 >
 > Why strmap_set_lc, and not strmap_set?

 I was thinking of two IPv6 addresses with uppercase and lowercase hex
 characters that should be considered equal.  If we're sure that doesn't
 happen, strmap_set should be fine.

 > Should "connections" be static?

 Yes!  Fixed in the updated heartbeat_uniqueips branch.

 I also found another problem with strmap_t not liking NULL values, even
 though we don't care about values.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5083#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs