[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #16990 [Tor Browser]: Circuit visualizer stops working after some time



#16990: Circuit visualizer stops working after some time
-------------------------------------------------+-------------------------
 Reporter:  cypherpunks                          |          Owner:
     Type:  defect                               |  arthuredelstein
 Priority:  Medium                               |         Status:
Component:  Tor Browser                          |  needs_review
 Severity:  Normal                               |      Milestone:
 Keywords:  tbb-torbutton, tbb-circuit-display,  |        Version:
  TorBrowserTeam201602                           |     Resolution:
Parent ID:                                       |  Actual Points:
  Sponsor:                                       |         Points:
-------------------------------------------------+-------------------------

Comment (by arthuredelstein):

 Replying to [comment:34 cypherpunks]:
 > Replying to [comment:32 arthuredelstein]:
 >
 > > I'm posting a fix for that specific issue here, for review:
 > >
 > > https://github.com/arthuredelstein/torbutton/commit/16990+3
 >
 > Your "multilineCommandInProgress" is really a multi line response. Since
 multi line commands (the commands you are sending to Tor) are allowed in
 the control spec, your variable is poorly named.
 >
 > Section 2.2 of the control spec doesn't apply for the response. Section
 2.3 applies and is incomplete:
 > https://trac.torproject.org/projects/tor/ticket/18224

 Phooey, you're right. There's a description of multiline values in Section
 3.9. Here's a version with revised comments:

 https://github.com/arthuredelstein/torbutton/commit/16990+4

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16990#comment:35>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs