Re: [tor-bugs] #17178 [Tor]: Rendezvous Single Onion Services: One-Hop Intro Point and Rendezvous

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#17178: Rendezvous Single Onion Services: One-Hop Intro Point and Rendezvous
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:
     Type:  enhancement                          |         Status:
 Priority:  High                                 |  needs_review
Component:  Tor                                  |      Milestone:  Tor:
 Severity:  Normal                               |  0.2.8.x-final
 Keywords:  028-triaged, tor-hs,                 |        Version:
  TorCoreTeam201602                              |     Resolution:
Parent ID:                                       |  Actual Points:
  Sponsor:  SponsorU                             |         Points:  large
-------------------------------------------------+-------------------------

Comment (by teor):

 Replying to [comment:36 asn]:
 > Small review.
 >
 > How come `assert_circ_onehop_ok()` is a macro? Having it as a macro
 makes it look kinda ugly and also it's hidden in a header file.

 Because the assertions correspond to the lines in the source file where
 the macro is used.
 Otherwise, I could modify it to be a macro that calls a function that
 takes `__FILE__` and `__LINE__`. We do that with one existing function
 already.

 >
 > ~~Also, I don't entirely understand~~:
 > {{{
 >     tor_assert((is_dir) || rend_allow_direct_connection((options)) || \
 >                (circ)->build_state->onehop_tunnel == 0); \
 > }}}
 > ~~it's different than the assert that it replaced. I would suggest to
 spread it out and maybe add some comments? Or is it something trivial that
 I don't get?~~
 > Hmm, I got it now. Maybe this whole comment is moot.

 For the record, it's an abstraction of the different checks for valid one-
 hop connections:
 * directory connections are one-hop
 * (Some) RSOS and Tor2web connections are one-hop
 * otherwise, the connection must not be one-hop.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17178#comment:37>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs