[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #16728 [Tor Browser]: Test cases for favicon isolation

#16728: Test cases for favicon isolation
------------------------------------------------+--------------------------
 Reporter:  mikeperry                           |          Owner:  boklm
     Type:  enhancement                         |         Status:
 Priority:  Medium                              |  needs_revision
Component:  Tor Browser                         |      Milestone:
 Severity:  Normal                              |        Version:
 Keywords:  tbb-testcase, TorBrowserTeam201602  |     Resolution:
Parent ID:                                      |  Actual Points:
  Sponsor:                                      |         Points:
------------------------------------------------+--------------------------
Changes (by gk):

 * keywords:  tbb-testcase, TorBrowserTeam201602R => tbb-testcase,
     TorBrowserTeam201602
 * status:  needs_review => needs_revision


Comment:

 Looks good. Just some nits: There are at least two comments that need to
 get updated including the favicon test as well (line 7/8 and line 107 in
 `browser_cacheFirstParty.js`). While you are trying to get rid of
 superfluous whitespaces, at the end of line 113 in
 `browser_cacheFirstParty.js` is another one.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16728#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs