Re: [tor-bugs] #21449 [Core Tor/Tor]: Make tor version parsing and version spec consistent

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#21449: Make tor version parsing and version spec consistent
--------------------------+----------------------------------
 Reporter:  teor          |          Owner:
     Type:  defect        |         Status:  new
 Priority:  Medium        |      Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  tor-spec      |  Actual Points:
Parent ID:                |         Points:  2
 Reviewer:                |        Sponsor:
--------------------------+----------------------------------

Comment (by teor):

 The svn logic in tor_version_as_new_as doesn't work for git tags:
 {{{
   /* Here's why we don't need to do any special handling for svn
 revisions:
    * - If neither has an svn revision, we're fine.
    * - If the router doesn't have an svn revision, we can't assume that it
    *   is "at least" any svn revision, so we need to return 0.
    * - If the target version doesn't have an svn revision, any svn
 revision
    *   (or none at all) is good enough, so return 1.
    * - If both target and router have an svn revision, we compare them.
    */
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21449#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs