Re: [tor-bugs] #23873 [Core Tor/Tor]: Remove the return value of node_get_prim_orport()

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#23873: Remove the return value of node_get_prim_orport()
----------------------------+------------------------------------
 Reporter:  teor            |          Owner:  (none)
     Type:  enhancement     |         Status:  needs_revision
 Priority:  Medium          |      Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor    |        Version:
 Severity:  Normal          |     Resolution:
 Keywords:  technical-debt  |  Actual Points:
Parent ID:  #24403          |         Points:  1
 Reviewer:                  |        Sponsor:
----------------------------+------------------------------------

Comment (by teor):

 These checks are around the wrong way, they should say
 !tor_addr_port_is_valid(), because we want to use IPv6 when there is no
 valid IPv4:
 {{{
           } else if (node->ipv6_preferred ||
                      tor_addr_port_is_valid_ap(&ipv4_addr, 0)) {
 }}}

 {{{
   } else if (tor_addr_port_is_valid_ap(&ipv4_addr, 0)
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23873#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs