[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #25036 [Core Tor/Tor]: Tor 0.3.2 rejects connections to raw ipv6 addresses
#25036: Tor 0.3.2 rejects connections to raw ipv6 addresses
------------------------------------------+--------------------------------
Reporter: pastly | Owner: tbb-team
Type: defect | Status: needs_revision
Priority: High | Milestone: Tor:
| 0.3.3.x-final
Component: Core Tor/Tor | Version: Tor:
| 0.3.2.1-alpha
Severity: Normal | Resolution:
Keywords: regression ipv6 032-backport | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
------------------------------------------+--------------------------------
Changes (by teor):
* status: needs_review => needs_revision
Comment:
Replying to [comment:18 rl1987]:
> Preliminary patch for this (and #25055):
https://github.com/rl1987/tor/commits/bugs_25036_25055
Did you replace every use of string_is_valid_hostname()?
Please add another unit test for a bracketed IPv6 address, rather than
replacing the existing raw IPv6 address test.
> I'm not exactly sure if it's okay to feed bracketed IPv6 string into
`tor_inet_pton`, but it seems to work.
Is tor_inet_pton() used for bracketed IPv6 strings elsewhere in the
codebase?
If not, how are they handled? Do it the same way.
If so, please update the function comment on tor_inet_pton(), and add a
unit test for tor_inet_pton() with a bracketed IPv6 address.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25036#comment:20>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs