[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #25171 [Core Tor/Tor]: Clarify 'recognized' field in tor-spec



#25171: Clarify 'recognized' field in tor-spec
--------------------------------------------+------------------------------
 Reporter:  atagar                          |          Owner:  (none)
     Type:  defect                          |         Status:  closed
 Priority:  Very Low                        |      Milestone:  Tor:
                                            |  0.3.3.x-final
Component:  Core Tor/Tor                    |        Version:
 Severity:  Trivial                         |     Resolution:  fixed
 Keywords:  tor-spec, doc, review-group-32  |  Actual Points:
Parent ID:                                  |         Points:
 Reviewer:  nickm                           |        Sponsor:
--------------------------------------------+------------------------------
Changes (by nickm):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Thanks, atagar!  I think this is as improvement over the existing spec.

 I've merged it, and made a couple of small tweaks in ef91cd6a595128.  The
 main one is that I don't think MAY is right here either: as I read RFC
 2119, "MAY "is for things that implementations are allowed to do, not for
 circumstances that will periodically occur.

 I've gone with this tweak on your wording:
 {{{
 +   When receiving and decrypting cells the 'recognized' will always be
 +   zero if we're the endpoint that the cell is destined for.  For cells
 +   that we should relay, the 'recognized' field will usually be nonzero,
 +   but will accidentally be zero with P=2^-32.
 }}}

 Thanks again for the spec fix!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25171#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs