[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #20395 [Metrics/Library]: Add capability to handle large descriptor files
#20395: Add capability to handle large descriptor files
-----------------------------+--------------------------------
Reporter: iwakeh | Owner: karsten
Type: defect | Status: needs_revision
Priority: Medium | Milestone:
Component: Metrics/Library | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: | Points:
Reviewer: iwakeh | Sponsor:
-----------------------------+--------------------------------
Comment (by iwakeh):
Replying to [comment:19 karsten]:
> Hmm. I see the benefits of such an API change. And we already have
#22678 that describes something very close, if not the same.
Yes!
>
> But should we separate the API change from this fix? In a way, I
consider it a bug that we're parsing an entire descriptor file before
passing all descriptors to the application. It's something we should have
changed when taking out `DescriptorFile`.
>
> How about I rewrite my patch to not make any changes to the API (in
particular `DescriptorParser`), and then we discuss the API change,
including how to do it in a backward-compatible fashion, as part of
#22678?
I think all effort is better spent renewing the API. You might name the
issue at hand a 'bug', but it really is not. The issues we're dealing
with are historically grown design decisions that should be modernized
now, not patched and stitched to last longer. There is no way around the
API change, so the sooner the better.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20395#comment:20>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs