[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #29144 [Core Tor/Tor]: Log the correct "auto" port number for listening sockets



#29144: Log the correct "auto" port number for listening sockets
-------------------------------------------------+-------------------------
 Reporter:  kjak                                 |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.1.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  041-proposed, 035-backport,          |  Actual Points:
  040-backport                                   |
Parent ID:                                       |         Points:  0.1
 Reviewer:  catalyst                             |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  merge_ready => needs_revision


Comment:

 Actually, I will do the cherry-pick, because our draft merge policy says:
 {{{
  * For patch quality: We should make sure that every commit to Tor is
     reviewed and double-checked for conformance.

 …

 4. What patches can be merged without review?

 The following items do not need a reviewer or a separate merger:

 Putting out releases:
    * Creating the ChangeLog and ReleaseNotes
    * Bumping the version number
    * Creating a signed tag

 Typo fixes in comments.
 }}}

 But it seems redundant to require someone to do the cherry-pick, someone
 else to review it, and then a third person to merge. We could probably get
 away with 2 people.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29144#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs