[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

[tor-bugs] #4919 [Pluggable transport]: obfsproxy: Wrong sizeof target in pending_socks_cb()

#4919: obfsproxy: Wrong sizeof target in pending_socks_cb()
---------------------------------+------------------------------------------
 Reporter:  asn                  |          Owner:  asn
     Type:  defect               |         Status:  new
 Priority:  normal               |      Milestone:     
Component:  Pluggable transport  |        Version:     
 Keywords:                       |         Parent:     
   Points:                       |   Actualpoints:     
---------------------------------+------------------------------------------
 `network.c:pending_socks_cb()`
 {{{
 ...
     struct sockaddr_storage ss;
     struct sockaddr *sa = (struct sockaddr*)&ss;
     socklen_t slen = sizeof(&ss);
 ...
     if (getpeername(bufferevent_getfd(bev), sa, &slen) == 0) {
 ...
 }}}

 `slen` gets filled with the size of the pointer, but we want it to be
 filled with the size of `sockaddr`.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4919>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs