[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #8090 [Stegotorus]: Add Debian-format copyright file for Stegotorus



#8090: Add Debian-format copyright file for Stegotorus
-------------------------+--------------------------------------------------
 Reporter:  rransom      |          Owner:  phobos  
     Type:  enhancement  |         Status:  assigned
 Priority:  minor        |      Milestone:          
Component:  Stegotorus   |        Version:          
 Keywords:               |         Parent:  #8099   
   Points:               |   Actualpoints:          
-------------------------+--------------------------------------------------
Changes (by zwol):

  * priority:  major => minor
  * type:  defect => enhancement


Comment:

 Replying to [comment:3 rransom]:
 >  * It's DEP-5, not DEP-3.

 I stand corrected.

 >  * If copyright and license information could be extracted
 automatically, Debian wouldn't have had to write a format spec for human-
 extracted license information.

 This does not change my opinion that having a human write an overview - in
 any format - of per-file licensing is not only a waste of effort, but will
 cause problems down the road, when, not if, the overview gets out of sync
 with the authoritative information in individual files.

 For absolute clarity: I will not accept a patch for this bug unless the
 DEP-5 information is machine generated at 'make dist' time.  The mechanism
 does not have to be fully general; it need only handle the files that are
 already in the repository.

 >  * `src/subprocess-unix.cc` contains copied code, but does not specify
 where the code was copied from or what exact license applies to it.

 Yeah, provenance tagging for the code in there could be better; this also
 applies to several other source files with code copied from Tor.  (If you
 file a separate bug report for ''that'', I will take responsibility for
 fixing it.)  However, the one function in that file that was copied from
 somewhere ''other'' than Tor is clearly labeled as such; the copyright
 information at the top of the file is accurate; and if a license other
 than the genericized 3-clause BSD that's in LICENSE applied, I would have
 put that in the label at the top of the file (see e.g. `src/base64.cc`).

 Please do not change the type or priority again.  Both I and SRI's legal
 department reviewed the licensing before SRI let me publish the code; if
 there had been any actual problem it would have been fixed then.  As such
 this really is only an enhancement.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8090#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs