[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #24821 [Core Tor/Tor]: Relay publishing malformed dirreq-v3-tunneled-dl
#24821: Relay publishing malformed dirreq-v3-tunneled-dl
--------------------------+------------------------
Reporter: atagar | Owner: (none)
Type: defect | Status: new
Priority: High | Milestone:
Component: Core Tor/Tor | Version:
Severity: Major | Resolution:
Keywords: | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
--------------------------+------------------------
Old description:
> Hi Nick, current extrainfo descriptors contain a relay publishing non-
> ascii content on its dirreq-v3-tunneled-dl line, breaking parsers...
>
> {{{
> % wget http://171.25.193.9:443/tor/extra/all
> % grep -P -n "[\x80-\xFF]" all
> 36575:dirreq-v3-tunneled-dl
> complete=156,timeout=4,running=0,min=6251,d1=38528,d2=55096,q1=73861,d3=90092
> =�hidserv-stats-end 2018-01-06 19:01:45 (86400 s)
> }}}
>
> Here's their full descriptor...
>
> {{{
> extra-info Pleiades BDA0BC3571FCCF656A962AA95E2DFF6450923BB5
> identity-ed25519
> -----BEGIN ED25519 CERT-----
> AQQABm6HAbEYutDUuq/ZI1LJSjM0nvEszAfpxB8OepMyLugTxXL+AQAgBAASAzfz
> x9hS7FiAtyMbScJpsTHj1uXoqWWUYTArUzxxIoHZyq/djybD/fymBea4UgAWx+H6
> 4zE8Kbz8OWukVfpFvMrwRQ/wTz5ODjA+V93WFE9Y+A/4EumvJthBdwALwwk=
> -----END ED25519 CERT-----
> published 2018-01-07 07:10:44
> write-history 2018-01-07 04:20:16 (14400 s)
> 1244441600,1433647104,1285724160,1217207296,1109211136,1398974464
> read-history 2018-01-07 04:20:16 (14400 s)
> 1218185216,1454397440,1310690304,1214405632,1098536960,1379415040
> dirreq-write-history 2018-01-07 04:20:16 (14400 s)
> 67653632,17948672,16737280,36403200,45087744,72242176
> dirreq-read-history 2018-01-07 04:20:16 (14400 s)
> 846848,649216,563200,952320,243712,913408
> geoip-db-digest E3C910F3B2A6C916C7BE33A943091EF57048B72C
> geoip6-db-digest E8BD5B2E6554C27F718F1222667C09680D75F799
> dirreq-stats-end 2018-01-06 19:01:45 (86400 s)
> dirreq-v3-ips
> fr=24,nl=16,us=16,be=8,ca=8,de=8,es=8,gb=8,gr=8,il=8,it=8,jp=8,lt=8,mp=8,pl=8,ru=8,th=8,tw=8,ua=8
> dirreq-v3-reqs
> fr=64,nl=40,us=24,ua=16,be=8,ca=8,de=8,es=8,gb=8,gr=8,il=8,it=8,jp=8,lt=8,mp=8,pl=8,ru=8,th=8,tw=8
> dirreq-v3-resp ok=160,not-enough-sigs=0,unavailable=0,not-found=0,not-
> modified=16,busy=0
> dirreq-v3-direct-dl complete=4,timeout=0,running=0
> dirreq-v3-tunneled-dl
> complete=156,timeout=4,running=0,min=6251,d1=38528,d2=55096,q1=73861,d3=90092=<94
> >^Shidserv-stats-end 2018-01-06 19:01:45 (86400 s)
> hidserv-rend-relayed-cells 208757 delta_f=2048 epsilon=0.30 bin_size=1024
> hidserv-dir-onions-seen 296 delta_f=8 epsilon=0.30 bin_size=8
> padding-counts 2018-01-06 19:07:19 (86400 s) bin-size=10000 write-
> drop=10000 write-pad=610000 write-total=680000 read-drop=10000 read-
> pad=710000 read-total=12810000 enabled-read-pad=10000 enabled-read-
> total=10000 enabled-write-pad=10000 enabled-write-total=10000 max-
> chanpad-timers=5
> router-sig-ed25519
> bicb0XSMXc9iNNIyuiwQrTX315t/917udtqXbAQzDIXvE+KSqTtNGpwPBgeIfzBSlQeJFdgmcBD1UUPOj8UaAw
> router-signature
> -----BEGIN SIGNATURE-----
> Vf5uqHeUpqhOa+4qCz4Ml5JR+S+HXZ2iKuPsSbXDh4HhkioQSeuotxkT/hrMCSu1
> SzgimRS7M+OMc1kGAwCOhmsVkBLJhVMqcEd0raZDEth1u+Cz7xdGrW3LmKZfi3p3
> MI3od/xLMsfr09At7wsSUiHGex8bwAt6ENPYqLWsY2Q=
> -----END SIGNATURE-----
> }}}
>
> Marking this as 'high' since this is choking Stem, and probably anything
> that'll read the CollecTor archives. I'll check with Karsten about how we
> want to handle the bad data on our end.
>
> There's two bugs here: first that the Pleiades is publishing this and
> second that the DirAuths are allowing malformed data into the consensus.
>
> Cheers! -Damian
New description:
Hi Nick, current extrainfo descriptors contain a relay publishing non-
ascii content on its dirreq-v3-tunneled-dl line, breaking parsers...
{{{
% wget http://171.25.193.9:443/tor/extra/all
% grep -P -n "[\x80-\xFF]" all
36575:dirreq-v3-tunneled-dl
complete=156,timeout=4,running=0,min=6251,d1=38528,d2=55096,q1=73861,d3=90092
=�hidserv-stats-end 2018-01-06 19:01:45 (86400 s)
}}}
Here's their full descriptor...
{{{
extra-info Pleiades BDA0BC3571FCCF656A962AA95E2DFF6450923BB5
identity-ed25519
-----BEGIN ED25519 CERT-----
AQQABm6HAbEYutDUuq/ZI1LJSjM0nvEszAfpxB8OepMyLugTxXL+AQAgBAASAzfz
x9hS7FiAtyMbScJpsTHj1uXoqWWUYTArUzxxIoHZyq/djybD/fymBea4UgAWx+H6
4zE8Kbz8OWukVfpFvMrwRQ/wTz5ODjA+V93WFE9Y+A/4EumvJthBdwALwwk=
-----END ED25519 CERT-----
published 2018-01-07 07:10:44
write-history 2018-01-07 04:20:16 (14400 s)
1244441600,1433647104,1285724160,1217207296,1109211136,1398974464
read-history 2018-01-07 04:20:16 (14400 s)
1218185216,1454397440,1310690304,1214405632,1098536960,1379415040
dirreq-write-history 2018-01-07 04:20:16 (14400 s)
67653632,17948672,16737280,36403200,45087744,72242176
dirreq-read-history 2018-01-07 04:20:16 (14400 s)
846848,649216,563200,952320,243712,913408
geoip-db-digest E3C910F3B2A6C916C7BE33A943091EF57048B72C
geoip6-db-digest E8BD5B2E6554C27F718F1222667C09680D75F799
dirreq-stats-end 2018-01-06 19:01:45 (86400 s)
dirreq-v3-ips
fr=24,nl=16,us=16,be=8,ca=8,de=8,es=8,gb=8,gr=8,il=8,it=8,jp=8,lt=8,mp=8,pl=8,ru=8,th=8,tw=8,ua=8
dirreq-v3-reqs
fr=64,nl=40,us=24,ua=16,be=8,ca=8,de=8,es=8,gb=8,gr=8,il=8,it=8,jp=8,lt=8,mp=8,pl=8,ru=8,th=8,tw=8
dirreq-v3-resp ok=160,not-enough-sigs=0,unavailable=0,not-found=0,not-
modified=16,busy=0
dirreq-v3-direct-dl complete=4,timeout=0,running=0
dirreq-v3-tunneled-dl
complete=156,timeout=4,running=0,min=6251,d1=38528,d2=55096,q1=73861,d3=90092=<94
>^Shidserv-stats-end 2018-01-06 19:01:45 (86400 s)
hidserv-rend-relayed-cells 208757 delta_f=2048 epsilon=0.30 bin_size=1024
hidserv-dir-onions-seen 296 delta_f=8 epsilon=0.30 bin_size=8
padding-counts 2018-01-06 19:07:19 (86400 s) bin-size=10000 write-
drop=10000 write-pad=610000 write-total=680000 read-drop=10000 read-
pad=710000 read-total=12810000 enabled-read-pad=10000 enabled-read-
total=10000 enabled-write-pad=10000 enabled-write-total=10000 max-chanpad-
timers=5
router-sig-ed25519
bicb0XSMXc9iNNIyuiwQrTX315t/917udtqXbAQzDIXvE+KSqTtNGpwPBgeIfzBSlQeJFdgmcBD1UUPOj8UaAw
router-signature
-----BEGIN SIGNATURE-----
Vf5uqHeUpqhOa+4qCz4Ml5JR+S+HXZ2iKuPsSbXDh4HhkioQSeuotxkT/hrMCSu1
SzgimRS7M+OMc1kGAwCOhmsVkBLJhVMqcEd0raZDEth1u+Cz7xdGrW3LmKZfi3p3
MI3od/xLMsfr09At7wsSUiHGex8bwAt6ENPYqLWsY2Q=
-----END SIGNATURE-----
}}}
Marking this as 'high' since this is choking Stem, and probably anything
that'll read the CollecTor archives. I'll check with Karsten about how we
want to handle the bad data on our end.
There's two bugs here: first that the Pleiades is publishing this and
second that the DirAuths are allowing malformed data into the consensus.
Cheers! -Damian
--
Comment (by atagar):
Ahhh, I was getting some deja vu about this and just realized why. We
encountered this before on #18656 which prompted #18938.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24821#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs