Re: [tor-bugs] #7590 [Core Tor/Tor]: [PATCH] New option LocalOutboundBindAddress

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#7590: [PATCH] New option LocalOutboundBindAddress
-------------------------------------------------+-------------------------
 Reporter:  ac                                   |          Owner:  (none)
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-client, tor-hs, hs-integration,  |  Actual Points:
  hs-app-support, review-group-28                |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 Review:
   * The `conn_get_outbound_address` function should have its documentation
 updated to explain what the new argument does, and how the function
 behaves now.
   * There should be tests for this, and a changes file.

 Otherwise this looks great to me!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7590#comment:25>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs