[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #23814 [Core Tor/Tor]: Remove non-exponential backoff directory download implementation
#23814: Remove non-exponential backoff directory download implementation
-----------------------------+------------------------------------
Reporter: teor | Owner: nickm
Type: defect | Status: needs_revision
Priority: Medium | Milestone: Tor: 0.3.3.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: review-group-31 | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
-----------------------------+------------------------------------
Changes (by asn):
* status: needs_review => needs_revision
Comment:
Hey, not very familiar with this part of the codebase, but did an attempt
to review it as part of r-g-31.
Commit `e0049ef022b8bf` LGTM. I liked the trick with `bf74194f` unintend
that code section on its own commit. I think we should also remove
`max_failures` from `download_status_is_ready()` tho.
I'm a bit curious on why we needed to do `5b55e15` if the function works
fine and we had tests for it. Is it to simplify the code? Should we do it
as part of another ticket, or we feel fine doing it in this one? Code
looks reasonable anyhow. We should also remove mention of `max_delay` from
func doc of `next_random_exponential_delay()`.
Marking this as `needs_rev` for the trivial fixes above. Feel free to put
it in `merge_ready` after that.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23814#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs