[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #32588 [Core Tor/Tor]: Setting ORPort [ipv6]:auto mistakenly advertises port 94



#32588: Setting ORPort [ipv6]:auto mistakenly advertises port 94
-------------------------------------------------+-------------------------
 Reporter:  arma                                 |          Owner:  neel
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.3.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.2.3.9-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  ipv6, memory-safety, security-low,   |  Actual Points:  0.6
  035-backport, 040-backport, 041-backport,      |
  042-backport                                   |
Parent ID:                                       |         Points:  1
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  needs_revision => needs_review
 * actualpoints:  0.4 => 0.6


Comment:

 Replying to [comment:13 dgoulet]:
 > Hmmm CI exploded for _one_ specific builds with interesting stacktrace:
 >
 > https://travis-ci.org/torproject/tor/jobs/627571176

 I forgot to check for a NULL IPv6 address.

 I re-did the patch, and split the commits into:
 * bug fix (and code movement)
 * refactoring

 I still need to write some tests, but I'd like a review :-)
 I also need to fix up #32822, because it's based on this branch.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32588#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs